Looks like something went wrong here, because this PR contains unrelated commits 😢

(I see that docker/docker-py#868 was merged btw)

@thaJeztah this PR is intentionally based on #2232 (the "unrelated commits") because stop signal support was introduced in version 1.21 of the remote API.

@dnephin advised basing this PR on #2232 and bumping DEFAULT_API_VERSION to 1.21.

When #2232 is merged, I will rebase on master.

@jstewmon ahh, I see now, sorry; usually "unrelated" commits are a result of a bad rebase. Sorry for the noise 😄

I've rebased this PR on master, now that v1.21 support has been merged.

I think this looks good, just a couple small changes to the test

@dnephin , Thanks for the quick review. I've removed those extraneous lines.

This needs another rebase. I believe you'll need to add this to the v2 schema as well.

Rebased and updated both service schema versions.

There's a test failure after the rebase

The tests fail because the docker-py version being used in CI is 1.6, and this PR depends on docker/docker-py#868 which is slated for docker-py 1.7.

The tests pass against the docker-py master branch.

I looked through the boilerplate code for tests to see if there was a way of skipping the test based on the version of module, but didn't see one.

Is there a standard way of handling yet-to-be-released dependencies on docker-py?

Use a git URL in requirements.txt, like this:

git+https://github.com/docker/docker-py.git@9deffc45a10bf0d03907002a0b3fa6b63c7ff817#egg=docker-py

LGTM!

LGTM